typecheck argument in _set when in dev mode #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Longer term I think we can make a case for having nice descriptive errors, with things like URLs and code samples, like this:
|
|
If you go the URL route, please don't append a serialised stack track like Angular 1.x does. It's really unreadable in DevTools. Maybe rather following RequireJS way of doing it. |
|
@Ryuno-Ki not sure what you mean, can you provide examples/screenshots? thanks |
|
https://stackoverflow.com/q/22287269 Links to error.angularjs.org (I'm on mobile right now). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342. I'm not entirely thrilled with the wording of this error message.
Putting this check in
._setas opposed to in.setseemed to be the most straightforward, as there's not really a good mechanism for having different versions of the helper functions themselves in dev vs regular mode.