Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component.set() should typecheck argument #342

Closed
tarjei opened this issue Mar 6, 2017 · 3 comments
Closed

component.set() should typecheck argument #342

tarjei opened this issue Mar 6, 2017 · 3 comments

Comments

@tarjei
Copy link

tarjei commented Mar 6, 2017

It's quite easy to call component.set(foo, bar) and get an error that does not relate to your current call. component.set should therefore do basic typechecking on it's arguments.
@PaulBGD
Copy link
Member

PaulBGD commented Mar 6, 2017

To save on final bundle size we could also just emit development warnings.

@tarjei
Copy link
Author

tarjei commented Mar 6, 2017

That would be perfect

@Conduitry Conduitry mentioned this issue Mar 6, 2017
Merged
Rich-Harris added a commit that referenced this issue Mar 6, 2017
@Rich-Harris
Merge pull request #343 from sveltejs/gh-342-typecheck-set-argument-i…
a463085 
…n-dev-mode

typecheck argument in _set when in dev mode
@tarjei
Copy link
Author

tarjei commented Mar 6, 2017

Wow fast turnaround! Kudos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tarjei @PaulBGD