fix: prevent event delegation logic conflicting between svelte instances#17728
Merged
Rich-Harris merged 2 commits intomainfrom Feb 17, 2026
Merged
fix: prevent event delegation logic conflicting between svelte instances#17728Rich-Harris merged 2 commits intomainfrom
Rich-Harris merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 3516086 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
dummdidumm
approved these changes
Feb 17, 2026
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Feb 17, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.51.3 ### Patch Changes - fix: prevent event delegation logic conflicting between svelte instances ([#17728](#17728)) - fix: treat CSS attribute selectors as case-insensitive for HTML enumerated attributes ([#17712](#17712)) - fix: locate Rollup annontaion friendly to JS downgraders ([#17724](#17724)) - fix: run effects in pending snippets ([#17719](#17719)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes sveltejs/svelte.dev#1793. There are actually two fixes here, and either is sufficient to fix the playground, but they are complementary. First, we only add the delegated event handler after the component has successfully mounted, otherwise it will never get cleaned up if an error occurs during mount.
Second, instead of storing data on
event.__root(which leaks between instances), we reuse the existingevent_symbolto provide the necessary encapsulation. (I'll be honest I don't totally understand what this property is for anyway and can't be bothered to figure it out right now, but I'm sure it's important.)No test because I'm not really sure how you would test this; it requires a fairly esoteric setup.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint