Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reactive actions #13953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

adiguba
Copy link
Contributor

@adiguba adiguba commented Oct 26, 2024

Simple implementation for reactive actions on the use:action directive.

  • action can be a reactive value, and will be created/destroyed accordingly.
  • action can be null/undefined, and will be ignored.

Fix issues : #6754 #6942 #13555

Demo here REPL

Notes :

  • This PR changes the signature of the $.action() function. I don't know if this should be considered as an incompatibilit, and if we have to manage the 2 types of calls (before/after this PR)
  • I have not created the chanset, because I don't known what king of change to select : patch or minor ?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 26, 2024

⚠️ No Changeset found

Latest commit: e9b2737

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Oct 26, 2024

pnpm add https://pkg.pr.new/svelte@13953

commit: e9b2737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant