feat : support transition with hidden (poc) #13576
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible solution for #9976
It's simple to show/hide a node with the
hidden
attribute (ofstyle:display
), but there no way to use the svelte's transition with that, and the{#if}
block destroys its contents every time the condition changes, which is not necessarily desirable.This PR proposes a new modifier for the
transition:
directive :hidden
.With this modifier, the transition will only be applied when the hidden attribute is modified.
Example :
This would allow to show/hide elements using Svelte transitions.
Demo REPL here (edit : modified REPL to use
|this
instead of|hidden
)Remarks :
hidden
, but I couldn't find a better name...hidden
attribute is overridden by any CSSdisplay
value.It's required to have a global CSS like that :
Is it worth it?
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint