You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Attempted to fix the tbody case statically previously, but more involved cases were very hard to fix.
But I just thought of another idea: Special-Case runtime function for descending into tr elements, which checks if the node is a tbody and in that case descent once more. Maybe that could work?
I wouldn't consider this a bug, but given that Svelte 4 would patch mismatches from SSR HTML (such as the table case), and we no longer do that in Svelte 5, we need to just document this. We already capture most cases via SSR, but that doesn't take into account that Svelte 4 allowed the SSR to be different from the client. We only allow that in Svelte 5 in certain cases (like if blocks), so it will definitely be a migration note unless we want to support all types of mismatch like Svelte 4 did.
It's not just about hydration. It's about the fact that this works and this doesn't. It's an ugly breaking change and — since it's valid HTML — definitely a bug
Per #12628 (comment), I've changed my view of this. I think the compiler errors/warnings could be more informative, but that's a separate chunk of work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.