-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve playground ux + migrate to svelte 5 #12817
base: main
Are you sure you want to change the base?
Conversation
|
@Rich-Harris Had to patch |
Thank you, but I wish you had mentioned this somewhere before taking this on — the current playground is more or less on ice as we're working on an entirely new svelte.dev site. It's not open source yet, but it already has a bunch of Svelte 5 playground updates, and we're trying to minimise how much of a clusterfuck it'll be to port over changes from the preview site (otherwise there's a whole bunch of changes I'd have made to the preview playground already) |
I'll hold off on the more complicated sourcemap-related stuff then and stick to low-hanging fruit 👍 |
What I meant was we're not going to merge this PR - we can leave it open for reference when working on svelte.dev but beyond that it would be too disruptive |
Sounds good, I'd be interested in contributing to the new site once it is open. |
This migrates components from the svelte 5 playground to use svelte 5 and makes a few visual / functional tweaks. For example (left/right = before/after):
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint