Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve playground ux + migrate to svelte 5 #12817

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ottomated
Copy link
Contributor

@ottomated ottomated commented Aug 12, 2024

This migrates components from the svelte 5 playground to use svelte 5 and makes a few visual / functional tweaks. For example (left/right = before/after):
image

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: afdfb98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ottomated
Copy link
Contributor Author

@Rich-Harris Had to patch @rich-harris/svelte-split-pane to allow it to return it's current position (the repl was trying to bind to it when it wasn't bindable, which caused a bunch of jank).

@Rich-Harris
Copy link
Member

Thank you, but I wish you had mentioned this somewhere before taking this on — the current playground is more or less on ice as we're working on an entirely new svelte.dev site. It's not open source yet, but it already has a bunch of Svelte 5 playground updates, and we're trying to minimise how much of a clusterfuck it'll be to port over changes from the preview site (otherwise there's a whole bunch of changes I'd have made to the preview playground already)

@ottomated
Copy link
Contributor Author

I'll hold off on the more complicated sourcemap-related stuff then and stick to low-hanging fruit 👍

@ottomated ottomated marked this pull request as ready for review August 13, 2024 00:27
@Rich-Harris
Copy link
Member

What I meant was we're not going to merge this PR - we can leave it open for reference when working on svelte.dev but beyond that it would be too disruptive

@ottomated
Copy link
Contributor Author

What I meant was we're not going to merge this PR - we can leave it open for reference when working on svelte.dev but beyond that it would be too disruptive

Sounds good, I'd be interested in contributing to the new site once it is open.

@benmccann benmccann marked this pull request as draft September 6, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants