fix: prevent whitespaces merging across component boundaries#12449
Merged
Rich-Harris merged 2 commits intomainfrom Jul 15, 2024
Merged
fix: prevent whitespaces merging across component boundaries#12449Rich-Harris merged 2 commits intomainfrom
Rich-Harris merged 2 commits intomainfrom
Conversation
The logic that was there didn't take components into account. The underlying problem is that the parent isn't properly set to `Fragment` in all cases because of nested `visit` calls we do in some places. Fixes #12447
🦋 Changeset detectedLatest commit: f43cf23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trueadm
approved these changes
Jul 15, 2024
trueadm
pushed a commit
that referenced
this pull request
Jul 16, 2024
* fix: prevent whitespaces merging across component boundaries The logic that was there didn't take components into account. The underlying problem is that the parent isn't properly set to `Fragment` in all cases because of nested `visit` calls we do in some places. Fixes #12447 * update test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic that was there didn't take components into account. The underlying problem is that the parent isn't properly set to
Fragmentin all cases because of nestedvisitcalls we do in some places.Fixes #12447
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint