-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export add snippet symbol func #12008
Conversation
|
7f6a602
to
079aa2c
Compare
@Rich-Harris @Conduitry Hello! Could you please preview this PR? |
We're aware of the issue, but this isn't the solution we plan to go with. We don't want people using private APIs as these are subject to change without warning. We have a rough design for a solution that we think would work for Astro but we haven't had a chance to test it out yet — more soon |
@Rich-Harris It's cool, and it's the right thing to do. Thanks for the explanation. |
079aa2c
to
240913e
Compare
@Rich-Harris My suggestion:
This is a critical issue. Unfortunately, this problem makes it impossible to release our project. Currently Astro cannot use Svelte 5 at all. Please give us a temporary solution to the problem. 🙏 |
As a temporary workaround an older version works with Astro... |
@nzoschke I need one fix that came in v5.0.0-next.153. |
240913e
to
b8eda2b
Compare
cc @bluwy i'm not sure if the integration was ever working with Svelte 5 or not. If so can we revert using this symbol? |
I am working on a project using Astro and svelte integration. It works with svelte 5 but breaks after v5.0.0-next.133. I have also been waiting for this to be fixed. |
Broken for me as well. I'm currently using the latest version 5.0.0-next.166. |
Can stealing the symbol be a temporary solution? |
Closing this in favour of #12409. |
Hello!
Astro uses
add_snippet_symbol
func: https://github.com/withastro/astro/blob/main/packages/integrations/svelte/client-v5.js#L2When I use the latest version of Svelte 5 with Astro I get an error:
This export was removed in this PR: 4365562
Please bring back the export of this feature so that you can use Svelte 5 with Astro.
Issue in Astro: withastro/astro#11149