chore: simpler <svelte:element> hydration#11773
Merged
Rich-Harris merged 7 commits intomainfrom Jun 6, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 4831a8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
There's #10997 which is the more general issue about this - is this something we can apply more broadly in here aswell, or is |
Member
Author
|
I suspect the patterns will apply broadly, but there'll be enough finicky details in the implementation that it'll be a piecemeal process. Case in point — I'm working on CSS custom property wrappers as part of this PR as well, and it's proving finicky because we currently implement them in a backwards way |
trueadm
approved these changes
May 27, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occurred to me that we can apply the ideas in #11770 piecemeal with the current approach to hydration and still see benefits.
This makes
<svelte:element>more efficient — in SSR, it skips the opening hydration marker:As such,
hydrate_anchorno longer needs to traverse the parent element just to populatehydrate_nodeswith a single element whose identity we already know. We do still need to keep a closing anchor, to handlethisgoing from falsy back to truthy.TODO:
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint