breaking: warn on self-closing non-void special elements#11244
Closed
jrmajor wants to merge 2 commits intosveltejs:mainfrom
Closed
breaking: warn on self-closing non-void special elements#11244jrmajor wants to merge 2 commits intosveltejs:mainfrom
jrmajor wants to merge 2 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6ae0a93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
afeb5b1 to
d7f5f59
Compare
5 tasks
Contributor
Author
|
Closing, as decided in #11245. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11114, but for special elements, so that they're treated more consistently with HTML elements.
I should have opened an issue for that first, so please treat it like a place for discussion. No hard feelings if it doesn't get merged :)
This PR adds warnings only for
<svelte:head>and<svelte:fragment>, since these are the only elements that don't really make sense without content.<svelte:options>,<svelte:window>,<svelte:document>and<svelte:body>should never have content, so I've opened #11245 to treat them like void tags.<slot>is deprecated anyway.Other special elements sometimes feel like void tags, and sometimes not, so I didn't touch them:
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint