fix: possible name clash in hoisted functions#11237
Merged
dummdidumm merged 2 commits intosveltejs:mainfrom Apr 19, 2024
paoloricciuti:fix-name-clash-in-hoisted-fn
Merged
fix: possible name clash in hoisted functions#11237dummdidumm merged 2 commits intosveltejs:mainfrom paoloricciuti:fix-name-clash-in-hoisted-fn
dummdidumm merged 2 commits intosveltejs:mainfrom
paoloricciuti:fix-name-clash-in-hoisted-fn
Conversation
🦋 Changeset detectedLatest commit: 812d7fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Svelte 5 rewrite
This come up on Discord here. Basically if you are accessing a store with the auto-subscription AND normal store object in a hoisted function it will generate the parameters with double the occurences of
storeleading to a Syntax error.See the problematic code
This fixes this by safe pushing an identifier in the parameter array only if it's not already present.
I've also added a test that is failing before the fix...i was not super sure how to properly do it so i just left the config basically void without asserting anything but it was failing before and it is not failing now.
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4and notmain.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint