chore: tidy up server exports #10972
Conversation
|
| export function beforeUpdate() {} | ||
| export function mount() { | ||
| throw new Error('mount(...) is not available on the server'); | ||
| } |
There was a problem hiding this comment.
Previously it was possible to use client APIs and its runtime in a server context, assuming the Dom APIs are shimmed. This most likely happens when using test runners. Are we ok with this use case no longer being possible? (The test runner case would need adjustments for export conditions, if that doesn't happen already automatically)
There was a problem hiding this comment.
I think this approach will lead to less confusion in general — if people expect mount to work without any configuration changes to their test runner or whatever, then they will probably expect things like unstate to work (which it won't), and things are very likely to break in future. This way, we force people to do things the right way from the get-go
Rather than re-exporting client code, the server entry file should implement things that can be exported from
svelte. This means duplicating some context-related code, but it means we can be much more efficient about what goes into server bundles, and what objects get created during SSR.