feat: nested CSS support #10491
Merged
feat: nested CSS support #10491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 91d02cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
found a bug, marking as draft until the morning |
* fix traversal, but break some other stuff * man this is fucken hard * fixes * getting closer * be conservative for now * tidy * invert * invert * simplify * switch * for now * progress * i think it works? * fix * tidy up * revert some stuff * remove some junk * handle weird cases * update * tweak * shrink * changeset --------- Co-authored-by: Rich Harris <[email protected]>
Rich-Harris
added a commit
that referenced
this pull request
Feb 17, 2024
* failing test for :is(...) * simplify * trim * factor out truncate function * pass stylesheet around * recurse into :is and :where * fix types * fix types * almost there * gah so close * tada * changeset * simplify * feat: nested CSS support (#10491) * parse nested CSS * tests * track parent rules * some progress * switch it up * pruning * works * changeset * lint * error early on invalid nesting selector * tidy * note to self * fix some specificity stuff * failing test * note to self * fix: correctly scope CSS selectors with descendant combinators (#10502) * fix traversal, but break some other stuff * man this is fucken hard * fixes * getting closer * be conservative for now * tidy * invert * invert * simplify * switch * for now * progress * i think it works? * fix * tidy up * revert some stuff * remove some junk * handle weird cases * update * tweak * shrink * changeset --------- Co-authored-by: Rich Harris <[email protected]> --------- Co-authored-by: Rich Harris <[email protected]> * Update playgrounds/sandbox/run.js * changeset --------- Co-authored-by: Rich Harris <[email protected]>
|
Wohoo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #10490 (this PR should be merged into that branch before that PR is merged into
main).This implements support for nested CSS, with pruning of unused styles. Credit to @AlbertMarashi for the initial implementation of this in #9549.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint