perf: use unchanged primitives directly in template attributes #10015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e7e1454 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benmccann
force-pushed
the
hoist-unmodified-var
branch
from
be626e1
to
e0af98b
Compare
benmccann
changed the title
benmccann
changed the title
|
I think we have to close this, sorry — the goal is to have a more holistic approach to hoisting that would result in fewer closures, and template optimisations would fall out of that. Better to wait until the codebase is stable enough to start that work in earnest rather than do it piecemeal and/or invest time in keeping this synced with main |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still additional cases that can be optimized. This PR is already a good size, so I didn't want to be exhaustive. We can always follow up with improvements. This is enough to allow us to optimize
@sveltejs/enhanced-img.We cannot inline variables referred to the in
<script>block that invoke any function or constructor during their initialization because we don't know if they may have randomness or side-effects. However, we have no such restriction with<script context="module">, so there's a performance benefit to using that construct. We will need to generate image URLs there in@sveltejs/enhanced-imgand users creating such constants manually should prefer to do so there as well.I had to update a test. It was asserting that we removed a space, but that's not really the important part of the test and this behavior of keeping the space seems better. What it was really testing was that "123" was not changed to "13" during hydration per #6832.
I had to add back the
GlobalBindingsconstant. I really couldn't think of any other way to avoid conflicting variable names at the top level. The existing solutions for avoiding global conflicts don't work for hoisting.This PR is based off some prior work from @paoloricciuti in the pre-alpha version.
There are some optimizations I left for esbuild, which Vite (and thus SvelteKit) uses as the default minifier. These improvements were added 0.19.11 (evanw/esbuild#3568).