Conversation
|
| throw new Error('Unhandled @type JsDoc->TS conversion: ' + js_code); | ||
| } | ||
| } else if (ts.isJSDocParameterTag(tag) && ts.isFunctionDeclaration(node)) { | ||
| // if (node.parameters.length !== 1) { |
There was a problem hiding this comment.
remove this? or add a comment about why it's disabled
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
I think some tests could be helpful at some point. I'm a little worried about modifying it since it affects multiple different sites with slightly different setups. But that can be a post-launch item
|
Ah yeah, tests are reallyyyy needed for this stuff, its too complicated and brittle. That is the cost of serving 2 sites at once though. Post launch, hopefully we can modify this logic to have learn.svelte.dev also be able to use it, with the weird +++ and --- syntax |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2 participants
Moves the rendering logic from svelte.dev here, to be used by kit.svelte.dev as well
Related PRs:
sveltejs/svelte#8757
sveltejs/kit#10187