Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade playwright to 1.30.0 #9756

Merged
merged 4 commits into from
Apr 25, 2023
Merged

chore: upgrade playwright to 1.30.0 #9756

merged 4 commits into from
Apr 25, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Apr 23, 2023

pinned to 1.30.0. newer versions fail on firefox

@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2023

⚠️ No Changeset found

Latest commit: 7961627

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gtm-nayan
Copy link
Contributor

tried to debug the firefox tests, looks like the build that playwright uses in that version doesn't handle reloads correctly, beforeunload isn't called, history.state is back to null when reloading, and even if I remove the parts where we set history.scrollState to manual, it doesn't scroll back to the previous location.

@benmccann benmccann changed the title chore: upgrade playwright to 1.32.3 chore: upgrade playwright to 1.30.0 Apr 24, 2023
@benmccann
Copy link
Member Author

It looks like it's Firefox 109 where it breaks based on the version of Playwright where it starts failing

@dummdidumm dummdidumm merged commit fb68c25 into master Apr 25, 2023
@dummdidumm dummdidumm deleted the playwright-1.32.3 branch April 25, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants