Make console.warn named function #7811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a7a7281 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
What's the reason for this? Stack trace? |
Contributor
Author
@dummdidumm Sorry for the delay! I created this PR in github.dev and it didn't prompt me for a description. Just updated the PR. |
Rich-Harris
approved these changes
Nov 26, 2022
Member
|
thank you! |
|
BTW this eats up the call trace because Shall I make a PR to fix this? Or does this need an issue for discussion first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some code that relies on introspecting the
nameofconsole.warn— some metaprogramming to provide dev-only logs. This update to makeconsole.warnan anonymous function means it no longer has a name, which breaks that assumption.Normally:
In SvelteKit dev: