Skip to content

Conversation

@cdcarson
Copy link
Contributor

@cdcarson cdcarson commented Sep 17, 2022

Fixes #6865. The return type of cookies.get is string|undefined, not string|void.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2022

🦋 Changeset detected

Latest commit: 6c69506

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cdcarson cdcarson changed the title change return type change return type of cookies.get back to string|undefined Sep 17, 2022
@cdcarson cdcarson marked this pull request as ready for review September 17, 2022 20:29
@cdcarson
Copy link
Contributor Author

This also should be changed in the docs. Pretty sure the happens when the PR is released, but just checking to see if I missed a step.

@dummdidumm dummdidumm merged commit ec456df into sveltejs:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return type of cookies.get

2 participants