fetch relative to layouts
#6559
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6337. Just a failing test for now, as I realised that there's no sense proceeding until #6541 is merged.
Couple of thoughts:
fetchfrom+layoutrelative to the layout's route, not the leaf's route #6337 we concluded that afetchinsrc/routes/foo/+layout.jsshould resolve relative to/foo/, not/foo. Since it would be very weird ifsrc/routes/foo/+page.jsthen resolved relative to/foo, it probably makes sense for all relative fetches to resolve as though the trailing slash were there.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0