-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[adapter-vercel] Make all root routes be called index instead of an empty string
#4731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adapter-vercel] Make all root routes be called index instead of an empty string
#4731
Conversation
🦋 Changeset detectedLatest commit: 7f6ff20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! it's actually way simpler — a route ID never ends with / (i.e. there's no possibility of separate nested and nested/ routes), so the only case we need to consider is the empty string
Co-authored-by: Conduitry <[email protected]>
The current implementation of
edge: true, split: truewill fail to deploy on Vercel because the Edge Function name is empty. This PR fixes that by renaming them toindexinstead.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0