hardcode team name #4675
Merged
hardcode team name #4675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pngwn
approved these changes
Apr 20, 2022
Member
|
Looks good to me, but I don't know how this could be failing linting now ... https://github.com/sveltejs/kit/runs/6102827202 |
Member
Author
|
The lint error is something unrelated that snuck in. Will be fixed by #4674 |
Conduitry
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secrets are redacted from GitHub Actions logs. Since we have a
TURBO_TEAMenvironment variable, to enable remote caching, we have a secret whose value issvelte. That results in some... interesting redactions:Since it's not really a secret that we're the
svelteteam, this replaces the secret with a hardcoded value.