Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSDoc annotations to templates #4621

Merged
merged 12 commits into from
Apr 15, 2022
Merged

Add JSDoc annotations to templates #4621

merged 12 commits into from
Apr 15, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 14, 2022

This PR builds on #4495, adding JSDoc annotations to template source files alongside the TypeScript annotations. These are stripped out of the TypeScript build and the no-typechecking build, while the TypeScript is stripped out of the JSDoc build and the no-typechecking build.

@changeset-bot
Copy link

changeset-bot bot commented Apr 14, 2022

🦋 Changeset detected

Latest commit: 16e4945

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris deleted the js-typechecking branch April 15, 2022 15:24
@@ -1,6 +1,7 @@
import { api } from './_api';
import type { RequestHandler } from '@sveltejs/kit';
import type { RequestHandler } from './index';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why RequestHandler is imported from ./index instead of @sveltejs/kit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those sweet sweet generated types

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

this confuses me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #4705

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Correct parsing, maybe it's time to merge 4705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants