-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make env vars a bit easier to understand/follow in adapter-node #4360
Conversation
🦋 Changeset detectedLatest commit: 8c68eb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/adapter-node/index.js
Outdated
const { | ||
out = 'build', | ||
precompress, | ||
environment: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would something like envAliases
make sense as a name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i feel like to be properly accurate it would need to be envVarAliases
which seems like a step too far
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
50 lines of code removed. awesome!
Co-authored-by: Maurício Kishi <[email protected]>
I find the environment variable options in
adapter-node
confusing in the extreme — they're options that set variables that allow you to set variables (that tell the app how to read variables, in the case of headers). The least we can do is avoid giving them inconsistent aliases on top of that.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0