Skip to content

Conversation

@aolose
Copy link
Contributor

@aolose aolose commented Mar 12, 2022

Allow display custom error message from shadow.

e.g

export function get() {
	return {
		body: {
			error: 'A custom error message'
		},
		status: 451
	};
}

fix: #4303

test:

cd packages\kit\test\apps\basics
npx  playwright test -g 'Display custom error message on client side shadow page'
npx  playwright test -g 'Display custom error message on server side shadow page'

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2022

⚠️ No Changeset found

Latest commit: af5b26e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

error = new Error('Failed to load data');
let error_message = 'Failed to load data';
try {
const { message } = await res.json();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be message or error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think error is more explicit.

@ItalyPaleAle
Copy link

Thank you for submitting a PR this quickly after I opened an issue :)

@Rich-Harris
Copy link
Member

Thank you — this is being worked on in #4032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot get props in errors returned by shadowed route

3 participants