Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] adapter-static: document prerender.default and info about disabling ssr in dev #4304

Merged
merged 8 commits into from
Mar 14, 2022

Conversation

Theo-Steiner
Copy link
Contributor

#4192 introduced a configuration setting for prerendering by default, which explicitly has to be set to true for adapter-static to work in non-SPA mode. Currently adapter-static only tells the user to do so when actually building, but having it in the docs is good for obvious reasons.
I also lumped in a small mention about disabling ssr in the handle() hook, to make developing an SPA with svelte-kit aligned with how it will actually works when built. I hope it's okay that I made a single PR for two changes, just let me know if changes are required!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2022

⚠️ No Changeset found

Latest commit: 6533100

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: Ben McCann <[email protected]>
@Rich-Harris Rich-Harris merged commit 87c89d7 into sveltejs:master Mar 14, 2022
@Rich-Harris
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants