-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
independent page type #4076
independent page type #4076
Conversation
🦋 Changeset detectedLatest commit: 565f81e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I guess we'll need to figure out a place to document this. Should it go in https://kit.svelte.dev/docs/modules#$app-stores or do we need to rig up a new section in https://kit.svelte.dev/docs/types? Also, do we need the |
packages/kit/types/ambient.d.ts
Outdated
*/ | ||
export const page: Readable<{ | ||
|
||
interface Page<Params extends Record<string, string> = Record<string, string>> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is going to close #3730 then I think this interface would need to be exported?
We already moved all of them to
We don't, surprisingly. They're still importable, it might be how |
In #4099, we're moving |
Closes #3730
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0