Skip to content

Conversation

@TheRealThor
Copy link

Currently the IP address (remote_addr) of clients that send a request is not available in endpoints or handle because the header object of the raw request is simply copied. However the remote_addr lies within the socket object of the raw request. The IP address of the requesting client is an important env needed for various use cases, like security and logging tasks. Hence, it is useful to include this env into the request object available for endpoints.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • [X ] This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2022

⚠️ No Changeset found

Latest commit: ae0016d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

This doesn't feel to me like the right way to handle this. It's not a real header. And, while req.socket.remoteAddress may be available in Node environments, it may not be in other environments that use this same utility function.

This feels like a job for https://kit.svelte.dev/docs/adapters#supported-environments-platform-specific-context for each relevant adapter.

@Rich-Harris
Copy link
Member

@Conduitry is right, stuff like this belongs in event.platform if it's needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants