-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] remove createIndexFiles
option, derive from trailingSlash
instead
#3801
Conversation
🦋 Changeset detectedLatest commit: 1e2a61e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for kit-demo canceled. 🔨 Explore the source changes: 1e2a61e 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6205694728e01d00087f8c8b |
This seems like a good idea to me. It'd be nice to do it automatically for |
Via https://www.zachleat.com/web/trailing-slash/, I found https://github.com/slorber/trailing-slash-guide. My takeaway is that we should indeed vary it based on I even wonder if it's worth exposing the option at all. I suspect there aren't really any cases where you'd need to control |
If you just drop the files in Apache or whatever you will need |
Is that true? If I create
|
Huh. TIL. I didn't think you could leave off the |
createIndexFiles
option, derive from trailingSlash
instead
lgtm after updating the validation message |
Co-authored-by: Ben McCann <[email protected]>
createIndexFiles
has been removed — it is now controlled by thetrailingSlash
option. See https://kit.svelte.dev/docs/configuration#trailingslash for more detailsOriginal PR message:
Fixes #3799.
One thing I've noticed about this option is that people (including myself) get confused talking about it because the default is
true
, and it feels unusual to have to explicitly set an option tofalse
. Two possible solutions:false
false
, and makeabout/index.html
instead ofabout.html
opt-inMight be worth doing a quick survey of popular static file hosts and seeing if
about.html
will work as expected in the majority of cases.Also, it might make sense to vary the default based on the value of
trailingSlash
or the host being used, which we could do on a per-adapter basis, but not globally.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0