-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove examples #3405
remove examples #3405
Conversation
|
✔️ Deploy Preview for kit-demo ready! 🔨 Explore the source changes: 63e784b 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e896fd84c7a60007d7dbfb 😎 Browse the preview: https://deploy-preview-3405--kit-demo.netlify.app |
Hmm. My initial reaction is that this would cause quite a bit of headache for me. I use the |
The way I solve this problem is that I have a "scripts": {
"dev": "node ../kit/packages/kit/src/cli.js dev",
"build": "node ../kit/packages/kit/src/cli.js build",
"package": "node ../kit/packages/kit/src/cli.js package",
"preview": "node ../kit/packages/kit/src/cli.js preview",
"lint": "prettier --ignore-path .gitignore --check --plugin-search-dir=. .",
"format": "prettier --ignore-path .gitignore --write --plugin-search-dir=. ."
},
"pnpm": {
"overrides": {
"@sveltejs/kit": "../kit/packages/kit",
"@sveltejs/adapter-auto": "../kit/packages/adapter-auto"
}
} This is better, because I don't need to worry about git |
Created https://github.com/sveltejs/kit-sandbox, which makes local testing and development easier |
I think the contribution guide should probably also be updated. As this PR is already merged I'll create a new one for this. |
It might also be worthwhile to update the link in the sveltejs/hn.svelte.dev README, seeing how it's still the number one Google result for "hn.svelte.dev". (It's archived right now so there isn't anything I can do) |
updated. thanks for the reminder! |
I think the
examples
folder has probably outlived its usefulness, and the one example left in there (the HN clone) should be moved to sveltejs/sites: sveltejs/sites#272Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0