Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove examples #3405

Merged
merged 2 commits into from
Jan 19, 2022
Merged

remove examples #3405

merged 2 commits into from
Jan 19, 2022

Conversation

Rich-Harris
Copy link
Member

I think the examples folder has probably outlived its usefulness, and the one example left in there (the HN clone) should be moved to sveltejs/sites: sveltejs/sites#272

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2022

⚠️ No Changeset found

Latest commit: 63e784b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "hn.svelte.dev" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for kit-demo ready!

🔨 Explore the source changes: 63e784b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e896fd84c7a60007d7dbfb

😎 Browse the preview: https://deploy-preview-3405--kit-demo.netlify.app

@benmccann
Copy link
Member

Hmm. My initial reaction is that this would cause quite a bit of headache for me. I use the hn.svelte.dev example all the time when developing against Kit since it lives in the same repo. Perhaps I could use the basics app, but it lives a bit deeply nested within the repository and it doesn't really have an easily navigable homepage showing the various pieces of functionality that exist

@Rich-Harris
Copy link
Member Author

The way I solve this problem is that I have a sandbox app next to the kit repo, with the following in its package.json:

"scripts": {
  "dev": "node ../kit/packages/kit/src/cli.js dev",
  "build": "node ../kit/packages/kit/src/cli.js build",
  "package": "node ../kit/packages/kit/src/cli.js package",
  "preview": "node ../kit/packages/kit/src/cli.js preview",
  "lint": "prettier --ignore-path .gitignore --check --plugin-search-dir=. .",
  "format": "prettier --ignore-path .gitignore --write --plugin-search-dir=. ."
},
"pnpm": {
  "overrides": {
    "@sveltejs/kit": "../kit/packages/kit",
    "@sveltejs/adapter-auto": "../kit/packages/adapter-auto"
  }
}

This is better, because I don't need to worry about git

@Rich-Harris
Copy link
Member Author

Created https://github.com/sveltejs/kit-sandbox, which makes local testing and development easier

@nhe23
Copy link
Contributor

nhe23 commented Jan 20, 2022

I think the contribution guide should probably also be updated. As this PR is already merged I'll create a new one for this.

@benmccann
Copy link
Member

@nhe23 I sent a PR for that last night #3425

@nsmaciej
Copy link

It might also be worthwhile to update the link in the sveltejs/hn.svelte.dev README, seeing how it's still the number one Google result for "hn.svelte.dev". (It's archived right now so there isn't anything I can do)

@benmccann
Copy link
Member

updated. thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants