Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make adapter-static output progress #3264

Closed
wants to merge 1 commit into from
Closed

Conversation

iacore
Copy link

@iacore iacore commented Jan 9, 2022

Closes #3224

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • Ideally, include a test that fails without this PR but passes with it.

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@netlify
Copy link

netlify bot commented Jan 9, 2022

❌ Deploy Preview for kit-demo failed.

🔨 Explore the source changes: 64e66da

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61db0cb0ea321600080146ec

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2022

⚠️ No Changeset found

Latest commit: 64e66da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -26,13 +27,13 @@ export default function ({ pages = 'build', assets = pages, fallback, precompres

if (precompress) {
if (pages === assets) {
builder.log.minor('Compressing assets and pages');
builder.log(`Compressing assets and pages to directory: ${assets}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to remove .minor?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No — these should only be visible with --verbose. Rather than changing all these I think it would be better to have a single builder.log at the end of the process like

Wrote site to "${pages}"

or

Wrote pages to "${pages}" and assets to "${assets}"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly because how verbose vite's output is when building the site (listing every file built).

@Rich-Harris
Copy link
Member

Thank you — per #3264 (comment), I think we should just add a message at the end. Closing this in favour of #3274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

adapter-static completely silent
3 participants