-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make adapter-static output progress #3264
Conversation
❌ Deploy Preview for kit-demo failed. 🔨 Explore the source changes: 64e66da 🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61db0cb0ea321600080146ec |
|
@@ -26,13 +27,13 @@ export default function ({ pages = 'build', assets = pages, fallback, precompres | |||
|
|||
if (precompress) { | |||
if (pages === assets) { | |||
builder.log.minor('Compressing assets and pages'); | |||
builder.log(`Compressing assets and pages to directory: ${assets}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to remove .minor
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No — these should only be visible with --verbose
. Rather than changing all these I think it would be better to have a single builder.log
at the end of the process like
Wrote site to "${pages}"
or
Wrote pages to "${pages}" and assets to "${assets}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly because how verbose vite's output is when building the site (listing every file built).
Thank you — per #3264 (comment), I think we should just add a message at the end. Closing this in favour of #3274 |
Closes #3224
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0