Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only set cache-control: immutable when appropriate #3196

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Conversation

Rich-Harris
Copy link
Member

follow-up to #3193immutable probably doesn't do anything when max-age is 0, but there's still no reason to set it

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2022

🦋 Changeset detected

Latest commit: 076069f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 3, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 076069f

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d325242b042100079402e7

@Rich-Harris Rich-Harris merged commit a425e2e into master Jan 3, 2022
@Rich-Harris Rich-Harris deleted the no-immutable branch January 3, 2022 16:44
@Rich-Harris
Copy link
Member Author

abusing my admin powers to merge this one since caching bugs are no joke

@github-actions github-actions bot mentioned this pull request Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant