-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump eslint ecmaVersion to 2020 #2985
Conversation
🦋 Changeset detectedLatest commit: 24c0e52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ready for review? From a glance it looks good to me. We may want a changeset for this as well.
Hey @bluwy I think it's ready for review! I was a bit hesitant to open the PR for review prior to the corresponding issue triage/discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not verified the linting error myself, so I'm trusting that this fixes it :) But I don't think it would hurt either way since 2022 is just around the corner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we set everything to es2020
in #2604, but looks like this was a place that got overlooked
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0Description
reference #2984
Bumps eslint
ecmaVersion
to 2020, enables usage ofimport.meta.env
in JS files without error