[fix] upgrade minor deps. fetch-blob 3.1.3 needed for Netlify deploys#2714
[fix] upgrade minor deps. fetch-blob 3.1.3 needed for Netlify deploys#2714
fetch-blob 3.1.3 needed for Netlify deploys#2714Conversation
🦋 Changeset detectedLatest commit: 7ccc17e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
left a comment
There was a problem hiding this comment.
Do we want to update package.json too? That usually happens when running pnpm update -r
|
I don't really think it's necessary or possibly even desired as I think it'd make it slightly harder for users to pick older versions of libraries. It also would cause more merge conflicts with outstanding PRs. |
|
I'm still not clear of your point 😅 but I think updating to the latest would be better in the long term. Merge conflicts in outstanding PRs would already be affected by the lock file change, so having the Nevertheless it's just a question I've thought of, I'm fine with the PR as is too. |
|
With sem ver it's just as good to say |
|
Yeah good point too. It was that I find updating to the latest version cleaner, and would imply being the version we officially support (especially if we use a new feature from a minor version). But being able to easily resolve to a lower version is a plus too. |
Upgrade to
fetch-blob3.1.3 to make sure our deploys to Netlify succeed. This probably won't affect user projects which will need to do their own upgrades, but should help our own deploys of the examplesThis is only half of the fix. The other half is for Netlify to bump a dependency on their side. PR pending for that: netlify/cli#3533
Ref #1859