-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] allow users to override build target #2618
Conversation
- set `es2020` as default build target - allow users to override build target - let esbuild to check overriden build target satisfies the contraints of `es2020`
🦋 Changeset detectedLatest commit: 0a19bfb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nice. Thanks for implementing this! I probably wasn't clear in my comment on the issue, but my intention was that we shouldn't validate
But IMO I think it's more work than it's worth since there would always be edge cases where this behaviour is undesirable. So I'm in favour of removing the validation logic for now. Curious on what the other maintainers' thought on this. Other than that, the last thing is to add a changset via |
@bluwy Oh I see. Just moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Will wait for the others to check out before merging.
This PR tries to fix #2565 while ensuring the overridden value still satisfies the constraints of the default build target. It contains following changes:
es2020
as default build targetes2020
by injecting the default target into overridden target(s). This makes esbuild to check the constraints.Made a draft PR since it doesn't satisfies some items in the checklist. Please help me with additional commits.
Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0