Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing changeset for accidental master push #2574

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Oct 9, 2021

Add missing changeset for f2d5f49

notable updates are esbuild 0.13.4, vite 2.6.5 and vite-plugin-svelte 1.0.0-next.27 which prepares for an upcoming change to vites ssr api.

I also remember @benmccann talking about marked, which is updated to 3.0.7 now.

Adapters are added to the changeset because of the changed esbuild version

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2021

🦋 Changeset detected

Latest commit: 7641d74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dominikg dominikg requested a review from benmccann October 9, 2021 13:38
@benmccann
Copy link
Member

marked is only used in the tests, so as long as the tests pass it's fine

@dominikg dominikg merged commit 53b3ed3 into sveltejs:master Oct 9, 2021
@github-actions github-actions bot mentioned this pull request Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants