Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homepage to package.json #2425

Merged
merged 13 commits into from
Sep 15, 2021
Merged

Add homepage to package.json #2425

merged 13 commits into from
Sep 15, 2021

Conversation

frederikhors
Copy link
Contributor

@frederikhors frederikhors commented Sep 14, 2021

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2021

🦋 Changeset detected

Latest commit: a4b703f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sveltejs/adapter-begin Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch
create-svelte Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

Any changes to this file should be indented with tabs like the rest of the file, not with spaces.

I'm not sure how valuable of a change this is, but I would argue that, if we did add a homepage, it should be https://kit.svelte.dev/ - There is a separate package.json field for the repository URL.

@frederikhors
Copy link
Contributor Author

Any changes to this file should be indented with tabs like the rest of the file, not with spaces.

I'm not sure how valuable of a change this is, but I would argue that, if we did add a homepage, it should be https://kit.svelte.dev/ - There is a separate package.json field for the repository URL.

Done.

packages/kit/package.json Outdated Show resolved Hide resolved
@antony
Copy link
Member

antony commented Sep 14, 2021

Where does this information appear? We have this info in the root package, and if we wanted to put it in sub-packages, we'd want to put it into all of them rather than just one.

@dummdidumm
Copy link
Member

This will appear on npm, there will be links to the homepage/github repo then, which I agree should be done for all packages. To me it's always a little strange to see a package on npm without any link to github, which makes me think it's closed source or something like that.

@benmccann
Copy link
Member

this change seems like a good idea to me, but agree that it should be done for everything under packages/

@frederikhors
Copy link
Contributor Author

this change seems like a good idea to me, but agree that it should be done for everything under packages/

Done!

@benmccann
Copy link
Member

I was starting to suggest that the homepage for the adapters should be their directory in GitHub since that's where the docs for them are, but I think I changed my mind on that because the README already gets published on npm, so there's no value in clicking through to GitHub to see it

Lgtm!

@benmccann benmccann merged commit b02ea03 into sveltejs:master Sep 15, 2021
@frederikhors frederikhors deleted the patch-1 branch September 15, 2021 17:17
@benmccann
Copy link
Member

Is this supposed to be visible on npm? I don't see it https://www.npmjs.com/package/@sveltejs/adapter-static/v/1.0.0-next.19

@bluwy
Copy link
Member

bluwy commented Sep 16, 2021

It should be, but maybe it's because npm only parses the links based on the latest tag, not the next tag.

sidharthv96 added a commit to sidharthv96/kit that referenced this pull request Sep 19, 2021
* 'master' of https://github.com/sveltejs/kit: (322 commits)
  Version Packages (next) (sveltejs#2438)
  [fix] revert sveltejs#2354 and fix double character decoding a different way (sveltejs#2435)
  chore: update dependencies (sveltejs#2447)
  [docs] add link to envPrefix option in env var FAQ (sveltejs#2445)
  Fix invalid changeset. Thanks GitHub bot :-p
  [feat] use the Vite server options in dev mode (sveltejs#2232)
  [fix] provide valid value for `letter-spacing` CSS property in template (sveltejs#2437)
  [docs] fix typo (sveltejs#2443)
  [fix] add svelte field when packaging (sveltejs#2431)
  Version Packages (next) (sveltejs#2428)
  [chore] update lockfile
  [fix] update to TS 4.4.3 (sveltejs#2432)
  [chore] add links to repository and homepage to package.json (sveltejs#2425)
  docs: use fragment for prefetching link (sveltejs#2429)
  [fix] encodeURI during prerender (sveltejs#2427)
  Version Packages (next) (sveltejs#2420)
  revert change to versioning during release workflow
  chore: update vite-plugin-svelte (sveltejs#2423)
  [chore] expose Body generic to hook functions (sveltejs#2413)
  [feat] adapter-node entryPoint option (sveltejs#2414)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants