-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include esbuild config in adapter type definition #1954
Conversation
🦋 Changeset detectedLatest commit: 6494d96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes #1958 I think |
@@ -11,9 +11,9 @@ import { fileURLToPath } from 'url'; | |||
/** | |||
* @param {{ | |||
* esbuild?: (defaultOptions: BuildOptions) => Promise<BuildOptions> | BuildOptions; | |||
* }} options | |||
* }} [options] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an intentional change? Why only on some adapters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adapter-cloudflare-workers
,adapter-vercel
,adapter-netlify
, andadapter-node
all use esbuild, so this option should be available but not made mandatory.adapter-begin
is unmaintainedadapter-static
doesn't use esbuild, so it wasn't affected.
If you're referring to the specific line, that's JSDoc's way of specifying an optional parameter so that you can do something like adapter: adapterCfw()
without having to pass in an empty object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're referring to the specific line, that's JSDoc's way of specifying an optional parameter so that you can do something like
adapter: adapterCfw()
without having to pass in an empty object.
I was referring to the specific line, thanks for clarifying. I need to learn the JSDoc spec better.
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0