Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix returning null from endpoints #1886

Merged

Conversation

utkarshkukreti
Copy link
Contributor

@utkarshkukreti utkarshkukreti commented Jul 12, 2021

#1808 introduced a bug which converts null to {} (empty object) when returned from endpoints. This PR fixes it and includes a test for the fix.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

A recent change [1] introduced a bug which converts `null` to `{}`
(empty object) when returned from endpoints. This commit explicitly
checks for `undefined` and does not modify `null` responses.

[1]: sveltejs#1808
@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2021

🦋 Changeset detected

Latest commit: b9025a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@utkarshkukreti
Copy link
Contributor Author

I used typeof body === 'undefined' because the code above used it, but I think body === undefined would have identical behavior here? Any reason to prefer the former?

@ignatiusmb
Copy link
Member

Good catch! Would it make sense to check for other types as well outside of "object"?

Any reason to prefer the former?

typeof is safer and used it out of habit, but since we know body is already defined, we can probably omit it.

@benmccann benmccann force-pushed the fix-returning-null-from-endpoints branch from 2a90159 to b9025a2 Compare July 12, 2021 18:00
@benmccann benmccann merged commit 6da07b8 into sveltejs:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants