-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for writing an adapter API #1846
Conversation
|
6247669
to
2ad1f25
Compare
2ad1f25
to
31a2625
Compare
I think linking to each of the types when they're mentioned would significantly reduce time spent reading SvelteKit codebase searching for stuff, though that is in itself valuable and should probably be encouraged. As would showing which package That is if the goal of the docs is to not force people to copy/paste from another adapter. |
Which types do you mean? Like where it says |
For types I mean:
|
25094cd
to
5d075ae
Compare
…e updated to point to upcoming SvelteKit Adapters section on sveltesociety.dev
Thanks! Those were good suggestions. I'm going to go ahead and merge this to get something out there, but feel free to leave additional comments or send PRs against it |
* 'master' of github.com:sidharthv96/kit: (1114 commits) Version Packages (next) (sveltejs#1858) Bump vite-plugin-svelte to 1.0.0-next.12 (sveltejs#1869) [fix] preserve user defined config and files on `svelte-kit package` (sveltejs#1735) [fix] handle undefined body on endpoint output (sveltejs#1808) [fix] copy essentials files from root on packaging (sveltejs#1747) [docs] sort config alphabetically (sveltejs#1867) add config.kit.package.emitTypes option (sveltejs#1852) [fix] add $lib alias to js/tsconfig (sveltejs#1860) Pass along custom properties added to Error (sveltejs#1821) Version Packages (next) (sveltejs#1840) Improve grammar in packages FAQ Docs for writing an adapter (sveltejs#1846) Additional documentation around pnpx changeset usage [feat] expose Vite.js `mode` from `$app/env` (sveltejs#1789) Service worker files exclusion support (sveltejs#1645) chore: Enable `vite.server.fs.strict` internally by default (sveltejs#1842) Test with the latest version of Svelte (sveltejs#1848) [docs] don't need to run pnpm install twice Improve HN example docs [fix] correct `ReadOnlyFormData` generator implementation (sveltejs#1837) ...
People have always written adapters by copying an existing one. We should probably provide more guidance. This can probably be fleshed out a bit more, but hopefully it's a starting point that we can add to
@jthegedus @jpaquim let me know if you have any suggestions from your work on writing the Firebase and Deno adapters
@ryanb I hope this helps as you take a look at writing a Begin adapter. Let me know as you go through the process if there are things missing