adapter-vercel should respect esbuild configs #1732
Conversation
This patch attempts to solve sveltejs#1706 We pass through the esbuild configurations in svelte.config.cjs into the esbuild step of the vercel adapter. This is primarily to solve the case where we have external packages that are skipped by esbuild in adapater-node, but not adpater-vercel.
|
|
If we're going to make this change, I assume we should also make it in the other adapters that use |
|
There's a related PR that's attempting to pass esbuild options into |
| @@ -31,7 +31,8 @@ export default function () { | |||
| entryPoints: ['.svelte-kit/vercel/entry.js'], | |||
| outfile: join(dirs.lambda, 'index.js'), | |||
| bundle: true, | |||
| platform: 'node' | |||
| platform: 'node', | |||
| ...config?.kit?.vite()?.esbuild | |||
There was a problem hiding this comment.
I think that reusing vite's esbuild config here is not the best way. People way want to configure the two separately. E.g. see #1692 (comment)
|
@Nick-Mazuk any news ? |
This patch attempts to solve #1706
We pass through the esbuild configurations in svelte.config.cjs into the
esbuild step of the vercel adapter.
This is primarily to solve the case where we have external packages that
are skipped by esbuild in adapater-node, but not adpater-vercel.
Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts