fix: navigate to hash link when base element is present by PatrickG · Pull Request #15236 · sveltejs/kit

PatrickG · 2026-02-02T09:16:48Z

Also, I'm wondering if this part

				if (app.hash) {
					location.replace(url);
				}

is even needed. Because we do

history.replaceState(history_state, '', url);

right after it anyway.
@teemingc I think you implemented this.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

changeset-bot · 2026-02-02T09:16:52Z

🦋 Changeset detected

Latest commit: 3fa9628

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

teemingc · 2026-02-02T10:14:10Z

What you pointed out makes complete sense. My memory is failing me as to the redundancy (probably a mix up while sorting out merge conflicts). I haven't looked into it yet but it's probably fine to try removing it and running tests (our CI should test the behaviours on multiple platforms/browsers). Otherwise, I'll look into manually testing this sooner than later this week

teemingc

Thanks! Looks good. I replaced the test timeout with an assertion and tried to make the confusing code block we talked about less confusing by omitting the url from the history api call

PatrickG · 2026-02-03T18:02:53Z

@teemingc ~~Is the test without the timeout still failing without the changes?~~ yep
Also, I still don't undestand why the extra location.replace is needed. According to the comment it just changes the url back to #/path#hash. IMO history.replaceState(history_state, '', url) should do exactly the same.

I just tested to remove the extra location.replace, and it seems like all tests are passing.

teemingc · 2026-02-03T18:40:23Z

Yeah, maybe we should get rid of it and simplify it to just history.replaceState. Can you open a chore PR for that?

PatrickG · 2026-02-03T18:45:38Z

yep

th0rgall · 2026-02-04T12:46:20Z

Thank you both for fixing this so swiftly! My project is currently doing fine without the <base> element, but I'm sure this will avoid a confusing bug for someone at some point in the future 👍

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @sveltejs/adapter-netlify@6.0.0 ### Major Changes - breaking: `platform.context` is now the [modern Netlify Functions (\[#15203\](#15203)) context](https://docs.netlify.com/build/functions/api/#netlify-specific-context-object) Previously, this was the [AWS Lambda-style context](https://github.com/netlify/primitives/blob/c1ae30f2745f0a73e26e83334695e205a04ab47d/packages/functions/prod/src/function/handler_context.ts). If you were using this in your app (unlikely), you will need to update your code to read from new fields. ### Minor Changes - feat: Migrate to the modern Netlify Functions API ([#15203](#15203)) The Netlify adapter now generates "v2" Netlify Functions, which uses modern standards (ESM, `Request`, `Response`) instead of the legacy "Lambda-compatible" or "v1" format. Under the hood, this greatly simplifies the adapter code and improves maintainability. For more details on features this unlocks for your SvelteKit app, see <https://developers.netlify.com/guides/migrating-to-the-modern-netlify-functions/>. - feat: allow configuring redirects in `netlify.toml` ([#15203](#15203)) The limitation of only being able to configure redirects via the `_redirects` file has been removed. ### Patch Changes - fix: populate `App.Platform` with `context` property ([#15203](#15203)) - Updated dependencies \[[`37293a5`](37293a5), [`5d05ca6`](5d05ca6), [`ed69b77`](ed69b77), [`b1fc959`](b1fc959), [`159aece`](159aece), [`c690579`](c690579), [`dc8cf2d`](dc8cf2d), [`ace2116`](ace2116), [`0f38f49`](0f38f49)]: - @sveltejs/kit@2.51.0 ## @sveltejs/kit@2.51.0 ### Minor Changes - feat: add `scroll` property to `NavigationTarget` in navigation callbacks ([#15248](#15248)) Navigation callbacks (`beforeNavigate`, `onNavigate`, and `afterNavigate`) now include scroll position information via the `scroll` property on `from` and `to` targets: - `from.scroll`: The scroll position at the moment navigation was triggered - `to.scroll`: In `beforeNavigate` and `onNavigate`, this is populated for `popstate` navigations (back/forward) with the scroll position that will be restored, and `null` for other navigation types. In `afterNavigate`, this is always the final scroll position after navigation completed. This enables use cases like animating transitions based on the target scroll position when using browser back/forward navigation. - feat: `hydratable`'s injected script now works with CSP ([#15048](#15048)) ### Patch Changes - fix: put preloads before styles ([#15232](#15232)) - fix: suppress false-positive inner content warning when children prop is forwarded to a child component ([#15269](#15269)) - fix: `fetch` not working when URL is same host but different than `paths.base` ([#15291](#15291)) - fix: navigate to hash link when base element is present ([#15236](#15236)) - fix: avoid triggering `handleError` when redirecting in a remote function ([#15222](#15222)) - fix: include `test` directory in generated `tsconfig.json` alongside existing `tests` entry ([#15254](#15254)) - fix: generate `tsconfig.json` using the value of `kit.files.src` ([#15253](#15253)) ## @sveltejs/adapter-cloudflare@7.2.7 ### Patch Changes - fix: error if `_routes.json` is in the `/static` public directory ([#12821](#12821)) - fix: correctly handle pathnames found in the `_redirects` file ([#12821](#12821)) - Updated dependencies \[[`37293a5`](37293a5), [`5d05ca6`](5d05ca6), [`ed69b77`](ed69b77), [`b1fc959`](b1fc959), [`159aece`](159aece), [`c690579`](c690579), [`dc8cf2d`](dc8cf2d), [`ace2116`](ace2116), [`0f38f49`](0f38f49)]: - @sveltejs/kit@2.51.0 ## @sveltejs/adapter-node@5.5.3 ### Patch Changes - fix: validate `ORIGIN` env var at startup ([#15045](#15045)) - chore(deps): update dependency `@rollup/plugin-commonjs` to v29 ([#14856](#14856)) - Updated dependencies \[[`37293a5`](37293a5), [`5d05ca6`](5d05ca6), [`ed69b77`](ed69b77), [`b1fc959`](b1fc959), [`159aece`](159aece), [`c690579`](c690579), [`dc8cf2d`](dc8cf2d), [`ace2116`](ace2116), [`0f38f49`](0f38f49)]: - @sveltejs/kit@2.51.0 ## @sveltejs/enhanced-img@0.10.1 ### Patch Changes - fix: replace erroneous `import.meta.DEV` with `import.meta.env.DEV` in generated code ([#15285](#15285)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

PatrickG added 3 commits February 2, 2026 10:00

test

10b2ef0

fix

1250510

changeset

58df3b1

teemingc added the router label Feb 2, 2026

format

4060f25

teemingc added 2 commits February 4, 2026 00:48

replace timeout with auto retrying assertion

0dd5583

we might not even need the url when restoring history state

3fa9628

teemingc approved these changes Feb 3, 2026

View reviewed changes

teemingc merged commit b1fc959 into sveltejs:main Feb 3, 2026
22 checks passed

github-actions bot mentioned this pull request Feb 3, 2026

Version Packages #15241

Merged

PatrickG mentioned this pull request Feb 4, 2026

chore: remove unnecessary location.replace call #15245

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: navigate to hash link when base element is present#15236

fix: navigate to hash link when base element is present#15236
teemingc merged 6 commits intosveltejs:mainfrom
PatrickG:issue-15235

PatrickG commented Feb 2, 2026

Uh oh!

changeset-bot bot commented Feb 2, 2026 •

edited

Loading

Uh oh!

teemingc commented Feb 2, 2026

Uh oh!

teemingc left a comment •

edited

Loading

Uh oh!

Uh oh!

PatrickG commented Feb 3, 2026 •

edited

Loading

Uh oh!

teemingc commented Feb 3, 2026

Uh oh!

PatrickG commented Feb 3, 2026

Uh oh!

th0rgall commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

PatrickG commented Feb 2, 2026

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

Uh oh!

changeset-bot bot commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

teemingc commented Feb 2, 2026

Uh oh!

teemingc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

PatrickG commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teemingc commented Feb 3, 2026

Uh oh!

PatrickG commented Feb 3, 2026

Uh oh!

th0rgall commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Feb 2, 2026 •

edited

Loading

teemingc left a comment •

edited

Loading

PatrickG commented Feb 3, 2026 •

edited

Loading