Skip to content

Conversation

@jycouet
Copy link
Contributor

@jycouet jycouet commented Oct 30, 2025


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

🦋 Changeset detected

Latest commit: bf6191c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jycouet jycouet marked this pull request as ready for review October 31, 2025 14:37
@benmccann
Copy link
Member

Is there an issue this fixes? We should probably also have a test for this. The base path stuff has been incredibly difficult to make work correctly

@svelte-docs-bot
Copy link

@jycouet
Copy link
Contributor Author

jycouet commented Oct 31, 2025

It's actually the first part of #14070 and sveltejs/svelte#16663 (and part 2 only withastro/astro#12611)

Part 1: Vite config options will be overridden

cd packages/kit/test/apps/basic
pnpm test:unit unit-test/client.spec.js

Before this PR:
image
After this PR:
image

This log is happening before vitest launches, so I'm not sure how to test this.

I admit that I don't really know why in config_env.command === 'serve' we were setting base to kit.paths.base without any fallback, and causes this log by default.

Part 2: transport was disconnected, cannot call "fetchModule"

I think it's a vitest thing, but didn't manage to find yet the root cause (present in v3 and v4)
Let's see later for this one, it's not linked with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants