Skip to content

Conversation

@blaine-arcjet
Copy link
Contributor

@blaine-arcjet blaine-arcjet commented Apr 16, 2025

This adds the edge-light condition to the esbuild.build() command used to bundle code for Vercel's Edge Runtime. I noticed that the condition wasn't respected when marking some dependencies as ssr.external even though the packages supported Edge Runtime via the edge-light condition.

This change brings the compilation more in line with Next.js, as it leverages the edge-light condition.

Adding the conditions configuration also requires manually adding module because it is only defaulted if nothing is configured.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    - I didn't see any tests for the adapters.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: d2088a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc added the pkg:adapter-vercel Pertaining to the Vercel adapter label Apr 18, 2025
Copy link
Member

@teemingc teemingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@teemingc teemingc merged commit ee81145 into sveltejs:main Apr 18, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Apr 16, 2025
@blaine-arcjet blaine-arcjet deleted the phated/vercel-edge-light-condition branch April 18, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:adapter-vercel Pertaining to the Vercel adapter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants