-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to invalidate a custom identifier on goto() #13256
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 107a9f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13256-svelte.vercel.app/ this is an automated message |
* state?: Record<string, any> | ||
* }} | ||
*/ | ||
const options = opts; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this just stores the object reference and we're still mutating the same object later on.
Can you add some tests as well to verify that it invalidates the correct load function when given a string, URL, or function? |
@eltigerchino done, are they good? |
Thanks! I'd wait for the other maintainers to take a look at this too to see if this is the right API. |
Related issue: #10659
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits