Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to invalidate a custom identifier on goto() #13256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xxmichas
Copy link

@xxmichas xxmichas commented Dec 30, 2024

Related issue: #10659

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 30, 2024

🦋 Changeset detected

Latest commit: 107a9f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13256-svelte.vercel.app/

this is an automated message

@eltigerchino eltigerchino added the feature / enhancement New feature or request label Dec 31, 2024
* state?: Record<string, any>
* }}
*/
const options = opts;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this just stores the object reference and we're still mutating the same object later on.

@eltigerchino
Copy link
Member

Can you add some tests as well to verify that it invalidates the correct load function when given a string, URL, or function?

xxmichas added a commit to xxmichas/kit that referenced this pull request Dec 31, 2024
@xxmichas
Copy link
Author

@eltigerchino done, are they good?

@eltigerchino
Copy link
Member

eltigerchino commented Dec 31, 2024

Thanks! I'd wait for the other maintainers to take a look at this too to see if this is the right API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants