Skip to content

Conversation

@linnil1
Copy link
Contributor

@linnil1 linnil1 commented Dec 11, 2024

closes #13121

The behavior in this PR is a little different from the code in the issue.
Here, the adapter will now also attempt to use wrangler.json if:

  • The wrangler.json file exists.
  • The config is set to default (wrangler.toml).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 45cf634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13148-svelte.vercel.app/

this is an automated message

@linnil1
Copy link
Contributor Author

linnil1 commented Dec 12, 2024

Copy link
Member

@teemingc teemingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@teemingc teemingc merged commit 99babf9 into sveltejs:main Dec 12, 2024
14 checks passed
@teemingc teemingc changed the title Support wrangler.json configuration file in adapter-cloudflare-workers feat: support wrangler.json configuration file in adapter-cloudflare-workers Dec 12, 2024
@teemingc teemingc mentioned this pull request Dec 12, 2024
6 tasks
@teemingc
Copy link
Member

Sorry, I was over-eager and forgot to check for a changeset #13151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support wrangler.json configuration file in adapter-cloudflare-workers

3 participants