Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate values for cache-control and content-type headers in dev mode #13114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JR-G
Copy link

@JR-G JR-G commented Dec 6, 2024

Fix for #12784

Adds validation for common HTTP headers in dev mode to help catch invalid values early:

  • Validates cache-control directives against standard values
  • Validates content-type format
  • Only active in dev mode

run pnpm dev from test/apps/basics and navigate to http://localhost:5173/headers/invalid. In your console you'll see:

[SvelteKit] Invalid cache-control directive "totally-invalid". Did you mean one of: max-age, public, private, no-cache, no-store, must-revalidate, proxy-revalidate, s-maxage, immutable, stale-while-revalidate, stale-if-error, no-transform, only-if-cached, max-stale, min-fresh
[SvelteKit] Invalid content-type value "not-a-real-type"

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 6, 2024

🦋 Changeset detected

Latest commit: adc6077

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13114-svelte.vercel.app/

this is an automated message

@JR-G JR-G force-pushed the 12784-warn-on-invalid-headers branch from cd07b38 to 72f42fd Compare December 6, 2024 15:36
@JR-G JR-G force-pushed the 12784-warn-on-invalid-headers branch from 72f42fd to e651a53 Compare December 6, 2024 15:41
@JR-G JR-G marked this pull request as ready for review December 6, 2024 15:44
@benmccann benmccann changed the title feat: warn on invalid headers feat: validate values for cache-control and content-type headers in dev mode Dec 6, 2024
@JR-G JR-G force-pushed the 12784-warn-on-invalid-headers branch from e651a53 to adc6077 Compare December 8, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants