-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: inline server stylesheets instead of client stylesheets #13068
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 3b44f22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
} | ||
|
||
// ignore dynamically imported stylesheets since we can't inline those | ||
css.filter(asset => client_stylesheets.has(asset.fileName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for understanding: asset.fileName
is always different between client and server, i.e. there's no chance of this accidentally filtering out a server stylesheet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they're always different. The client stylesheets correspond to the node index number while server stylesheets are always "_page" or "_layout".
preview: https://svelte-dev-git-preview-kit-13068-svelte.vercel.app/ this is an automated message |
fixes #6720
This PR changes the inlined stylesheet from client to server so that the paths for imported assets in the CSS such as fonts are correct when the document first loads. In comparison, the client stylesheet links are relative by default, so they always link to the wrong place
e.g.,
URL("./font.woff")
links toexample.com/font.woff
when loaded from the document instead ofexample.com/_app/immutable/...
. However, when loaded from an external stylesheet, the link is correct because the stylesheet is already loaded from/_app/immutable/...
.TODO:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits