Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: generate plaintext 404.html for Cloudflare Pages, instead of SPA-style fallback #11596

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Jan 10, 2024

Alternative to #9762. Closes #9386. Instead of generating an SPA-style fallback page, we render a plaintext Not Found page, which is sufficient for the case where a request is made for a missing asset that is covered by an exclude rule. For all other requests, we will hit the worker, which will generate the correct 404 page.

Today:

With this PR:


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 97aaa63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

eltigerchino
eltigerchino previously approved these changes Jan 11, 2024
Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The issue has always been because of the wildcard exclude of our immutable assets and this solves that (albeit we don’t get the nice looking error page but it’s unlikely someone navigates to /_app/* anyway).

EDIT: For those using wildcards for their page routes, fallback should be opt-in as mentioned in #9762 (comment)

If someone was messing around with the _routes file they should be prepared to deal with the whole “generate fallback” and “if building” shenanigans anyway

Copy link

@RowanAldean RowanAldean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks functional, not ideal. Seems safe to merge.

@eltigerchino eltigerchino self-requested a review January 11, 2024 01:06
@eltigerchino eltigerchino dismissed their stale review January 11, 2024 01:06

Opt-in for fallback generation

@eltigerchino eltigerchino removed their request for review January 11, 2024 01:07
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a little weird to have one path that behaves differently, but really shouldn't matter. I'm fine with this if it helps simplify things

packages/adapter-cloudflare/index.d.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sveltejs/adapter-cloudflare v2.2.0 always triggers hooks on build
4 participants