Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retain URL query string for trailing slash redirects to prerendered pages #11142

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

eltigerchino
Copy link
Member

@eltigerchino eltigerchino commented Nov 29, 2023

fixes #11138

Adds a check for the URL query string then adds it to the redirect location. Previously, the redirect location was just the pathname, so the query string was always omitted when we redirected. This affected vite preview, adapter-cloudflare, and adapter-cloudflare-workers. The added test only tests for vite preview (we have no cloudflare adapter tests).

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: ef7de9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann merged commit a4d9130 into master Nov 30, 2023
14 checks passed
@benmccann benmccann deleted the fix-trailing-slash-redirect-query branch November 30, 2023 16:38
@github-actions github-actions bot mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trailingSlash redirect does not preserve search params for prerendered routes
3 participants